Dwarf Fortress Bug Tracker - Dwarf Fortress
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010296Dwarf FortressDwarf Mode -- Tradepublic2017-09-25 15:322018-01-06 10:42
ReporterShonai_Dweller 
Assigned ToToady One 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSWindowsOS Version10
Product Version0.43.05 
Target VersionFixed in Version 
Summary0010296: Modded [ITEM_THIEF] Civ's merchants spam 'item stolen' messages when leaving
DescriptionThis is a well-known bug, but I honestly can't find it anywhere on the tracker. Apologies if it's out there somewhere. Figured it needed reporting since mythgen is about to mix up the world a lot.

Pretty much what it says at dfwiki really. If your modded civ has the tag [ITEMTHIEF], you'll be spammed with 'an item has been stolen' messages for everything in the wagon (whether previously yours or not) when merchants leave your site.
Steps To ReproduceAdd tag [ITEM_THIEF] to your civ.
Play Fortress Mode.
Trade, wait for merchants to leave.
Additional InformationExported wealth remains at zero, presumably negating all your wealth related triggers.
Can provide save if necessary.
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-09-25 15:32Shonai_DwellerNew Issue
2017-09-29 06:33FantasticDorfNote Added: 0036754
2017-09-29 06:34FantasticDorfNote Edited: 0036754bug_revision_view_page.php?bugnote_id=0036754#r14836
2017-09-29 18:58Shonai_DwellerNote Added: 0036755
2017-09-29 18:58Shonai_DwellerNote Edited: 0036755bug_revision_view_page.php?bugnote_id=0036755#r14838
2018-01-05 04:46Shonai_DwellerNote Added: 0037511
2018-01-05 09:08FantasticDorfNote Edited: 0036754bug_revision_view_page.php?bugnote_id=0036754#r15184
2018-01-05 09:48chaosvoltNote Added: 0037512
2018-01-05 14:49Shonai_DwellerNote Added: 0037513
2018-01-05 16:33Shonai_DwellerNote Edited: 0037513bug_revision_view_page.php?bugnote_id=0037513#r15186
2018-01-06 10:42LociNote Added: 0037516
2018-01-06 10:42LociStatusnew => resolved
2018-01-06 10:42LociResolutionopen => fixed
2018-01-06 10:42LociAssigned To => Toady One

Notes
(0036754)
FantasticDorf   
2017-09-29 06:33   
(edited on: 2018-01-05 09:08)
With modifications, this also applies onto intelligent livestock (modding obviously, like how tigermen used to be brought by elves pre-bugfix) upon leaving the map if the merchants are of a babysnatcher civ as kidnapping them indiscriminate of their age or circumstances for the intelligents brought by the merchants in cages.

So its a broader problem in itself. The last seen issue regarding merchants being branded theives was in regards to 0009780
___________________________________________________

Generally a word to the wise, issues with modded gameplay are usually lower priority generally as opposed to bugs that directly affect generic vanilla gameplay.
(0036755)
Shonai_Dweller   
2017-09-29 18:58   
Hence the option 'severity:minor'
If nobody ever reported bugs because they think they're too minor to be dealt with, they'd stay that way for the next 30 years.
(0037511)
Shonai_Dweller   
2018-01-05 04:46   
Well. Appears to be fixed in 44.03. Not sure why.
Will test a bit more, but just noticed it doesn't appear not happening any more. Have a whole load of Exported Wealth too.
(0037512)
chaosvolt   
2018-01-05 09:48   
Are you certain? I might have to test that then. In Kobold Kamp (my own variation of Kobold Camp) I inverted the logic by having humans, elves, and dwarves be item thieves, allowing trade to operate normally while still forcing hostility.
(0037513)
Shonai_Dweller   
2018-01-05 14:49   
(edited on: 2018-01-05 16:33)
I'm going to test in a new fortress first. Might be a result of a disappearing caravan bug or something. Certainly no spam last Autumn though. And I was paying attention after realising there may have been none the previous year.

--edit
Tested. Item thieves can now sell stuff to merchants without 'item stolen' spam and they even gain exported wealth. Um...thanks Toady!

I guess someone might want to test the babysnatcher stuff mentioned above before this gets properly closed.
(0037516)
Loci   
2018-01-06 10:42   
Thanks for the update!

I'm not sure bug-free slavery is a worthy goal, but it can be reported separately if it doesn't work in a current version.