Dwarf Fortress Bug Tracker - Dwarf Fortress
View Issue Details
0010419Dwarf FortressVegetationpublic2017-12-05 02:052017-12-06 22:22
CalmBit 
Loci 
normalminoralways
acknowledgedopen 
Arch Linux
0.44.02 
 
0010419: [HEAVY_BRANCH_RADIUS] and [BRANCH_RADIUS] cause crashes with moderate values
I tried to create a modded tree with [HEAVY_BRANCH_RADIUS:4] and [BRANCH_RADIUS:6] - basing it off the apple tree raw file so I knew my base was solid. I was getting random crashes at the "Cleaning game objects" stage of saving - the saves stayed intact, but the game window would close, and information about failed memory freeing (in various forms depending on the crash) would be output to stderr. Generated a lot of worlds to make sure it was my tree causing the crash, along with removing the raw file to confirm. After another set of generated worlds and some tweaking, I narrowed it down to both of those lines that seem to cause issues.

The crash, additionally, only seems to happen that one time in fortress mode, with no ill effects, but makes adventure mode all but unusable.
1. Create a custom tree raw with the following lines:

[HEAVY_BRANCH_RADIUS:4]
[BRANCH_RADIUS:6]

2. Generate a new world with the tree on the map.
3. Embark on a tile that is confirmed to have the custom tree (using a custom tile, for example)
4. Save the embark once it loads, and wait for the crash.
No tags attached.
Issue History
2017-12-05 02:05CalmBitNew Issue
2017-12-06 13:36LociNote Added: 0037241
2017-12-06 13:36LociAssigned To => Loci
2017-12-06 13:36LociStatusnew => acknowledged
2017-12-06 22:09CalmBitNote Added: 0037253
2017-12-06 22:22CalmBitNote Added: 0037254
2017-12-07 16:58CalmBitNote Edited: 0037254bug_revision_view_page.php?bugnote_id=0037254#r15023

Notes
(0037241)
Loci   
2017-12-06 13:36   
Reproduced crash in v0.44.02 by modding larch trees with given values.

It's worth noting that the largest value in vanilla is 3 (for saguaros), with every other plant 0-2. Applying your values to larch trees resulted in comically-deformed trees with solid blocks of heavy branches--perhaps the wiki's explanation of the 'BRANCH_RADIUS' tokens is ... inaccurate.
(0037253)
CalmBit   
2017-12-06 22:09   
Suffice to say, I was really just throwing values against the wall to see what stuck, and encountered the crash in my quest to make weirdly shaped trees. The wiki's explanation is cryptic, to say the least, and indeed doesn't seem to convey the nature of the token's purpose...
(0037254)
CalmBit   
2017-12-06 22:22   
(edited on: 2017-12-07 16:58)
Also worth noting is that I seem to have hit the upper limit of a tree that _doesn't_ immediately crash the game on embark - [BRANCH_RADIUS:7] seems to insta-crash with a similar memory freeing error.

EDIT: Additionally, if you copy/modify the saguaro raws to make [HEAVY_BRANCH_RADIUS:7], you get no such insta-crash, but the same crash upon saving.