Dwarf Fortress Bug Tracker - Dwarf Fortress
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001939Dwarf FortressGeneralpublic2010-05-17 23:402010-12-11 09:03
ReporterKamil 
Assigned ToBaughn 
PrioritylowSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.31.04 
Target VersionFixed in Version0.31.05 
Summary0001939: Double execution of recorded macros
DescriptionUsing the build-in macro recorder/player, after recording a designation to put some furniture in a room, replaying the recorded macro causes it to run twice.
Steps To Reproduce1) choose furniture to put, place the cursor in desired spot
2) begin recording macro (ctrl + r)
3) place some furniture for a room (e.g. door, bed, cabinet)
4) end recording (ctrl + r)
5) choose the same first furniture to put and place the cursor in another room
6) run the macro (ctrl + p)
Additional InformationMacros for digging designations seem not to be affected.
A workaround is to finish the macro in the same spot it was started (i.e. moving the cursor to the beginning, choosing the first furniture)
TagsNo tags attached.
Relationships
child of 0001920closed Baughn Stocks screen hangs on "stone" and then skips to next category 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-05-17 23:40KamilNew Issue
2010-05-18 14:04FootkerchiefNote Added: 0006974
2010-05-20 09:05KamilNote Added: 0007072
2010-05-20 09:06KamilIssue Monitored: Kamil
2010-05-20 09:29KamilNote Edited: 0007072bug_revision_view_page.php?bugnote_id=0007072#r2643
2010-05-20 09:56FootkerchiefRelationship addedparent of 0001990
2010-05-20 10:07KamilNote Edited: 0007072bug_revision_view_page.php?bugnote_id=0007072#r2644
2010-05-20 12:08FootkerchiefRelationship deletedparent of 0001990
2010-05-20 12:08FootkerchiefRelationship addedchild of 0001920
2010-05-28 22:230x517A5DNote Added: 0007458
2010-05-28 22:240x517A5DIssue Monitored: 0x517A5D
2010-06-04 10:38FootkerchiefTag Attached: Fixed in 31.05?
2010-06-06 08:41KamilNote Added: 0007793
2010-06-06 09:12FootkerchiefNote Added: 0007794
2010-06-06 09:12FootkerchiefStatusnew => resolved
2010-06-06 09:12FootkerchiefFixed in Version => 0.31.05
2010-06-06 09:12FootkerchiefResolutionopen => fixed
2010-06-06 09:12FootkerchiefAssigned To => Baughn
2010-06-09 06:45Toady OneStatusresolved => closed
2010-12-11 09:03DwarfuTag Detached: Fixed in 31.05?

Notes
(0006974)
Footkerchief   
2010-05-18 14:04   
Can anyone confirm this problem?
(0007072)
Kamil   
2010-05-20 09:05   
(edited on: 2010-05-20 10:07)
Correction, it seems to be connected to more complex and/or time consuming designations (digging also). It seems that, while the game processes the macro it "holds" the macro button leading to repeated command (increasing the init KEY_HOLD_MS value solved this problem, but that's just a workaround).
Increasing init's MACRO_MS value doesn't help though.

Edit:
It might be related to the z-stocks stone cursor jump-over.
(0007458)
0x517A5D   
2010-05-28 22:23   
I confirm this problem. I experienced exactly this with a floor-building macro, and worked around it by temporarily increasing KEY_HOLD_MS.
(0007793)
Kamil   
2010-06-06 08:41   
I no longer experience this problem in 0.31.05 version.
(0007794)
Footkerchief   
2010-06-06 09:12   
Excellent. Marking as fixed.