Anonymous | Login | Signup for a new account | 2024-12-05 12:17 PST |
Main | My View | View Issues | Change Log | Roadmap |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||||
0011813 | Dwarf Fortress | Dwarf Mode -- Interface, Announcements | public | 2021-10-05 06:39 | 2021-10-25 01:01 | ||||||
Reporter | Bumber | ||||||||||
Assigned To | |||||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||||
Status | new | Resolution | open | ||||||||
Platform | OS | OS Version | |||||||||
Product Version | 0.47.05 | ||||||||||
Target Version | Fixed in Version | ||||||||||
Summary | 0011813: '&' in nickname messes with announcement text | ||||||||||
Description | It looks like the announcement and report code uses '&' as an escape sequence. Putting "&r" in a dwarf's nickname or profession will split the announcement at that point and continue the rest two lines down. In other combinations, the '&' will display, but the next character in the string will be ignored. '&' in user text needs to be sanitized to "&&" at some point before ending up in an announcement. | ||||||||||
Tags | No tags attached. | ||||||||||
Attached Files | |||||||||||
Notes | |
(0041165) Bumber (reporter) 2021-10-25 00:53 |
There's also an issue in the related code where use of enough ampersands will cause the line to be cut at the wrong index, deleting text. I set custom professions on my sparring dwarves as "&&aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa&" and "&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&". gamelog.txt shows: "The &&aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa& strikes at the &&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&& but the shot is blocked!" Sparring report shows: "The &aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&&&&&&&&&&&&&&&&&&but the shot is blocked!" |
(0041166) Bumber (reporter) 2021-10-25 01:01 edited on: 2021-10-25 22:40 |
(There's also a hypothetical crash that could occur if the index to cut the line at underflows as a result of the above, but you'd need 71+ consecutive characters without a space on the smallest grid size of 80.) |
Issue History | |||
Date Modified | Username | Field | Change |
2021-10-05 06:39 | Bumber | New Issue | |
2021-10-25 00:53 | Bumber | Note Added: 0041165 | |
2021-10-25 01:01 | Bumber | Note Added: 0041166 | |
2021-10-25 22:40 | Bumber | Note Edited: 0041166 | View Revisions |
Copyright © 2000 - 2010 MantisBT Group |