Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0005843Dwarf FortressDwarf Mode -- Roomspublic2012-04-26 10:552018-06-11 15:37
ReporterQuietust 
Assigned ToLoci 
PrioritynormalSeverityminorReproducibilityhave not tried
Statusneeds feedbackResolutionopen 
PlatformOSOS Version
Product Version0.34.07 
Target VersionFixed in Version 
Summary0005843: Thoughts about tomb quality don't happen
DescriptionThought codes exist for dwarves being happy about the quality of their tomb when they grow a year older (or unhappy if it's substandard), but these thoughts never actually happen because the code is comparing the dwarf's current tomb quality to itself rather than the dwarf's desired tomb quality.

The corresponding thoughts for bedroom, dining room, and office quality all seem to work fine.
Additional InformationThis was originally observed while digging through the code for version 0.23.130.23a (the final 2D release), and it still seems to be present in version 0.34.07.
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0022381)
kwieland (reporter)
2012-04-26 12:56

So that confirms what I found, that in the first 3d versions, the happiness of a dwarf didn't matter if your dwarf had a tomb or not.
(0023469)
Quietust (reporter)
2012-08-17 08:18

It didn't matter in the 2D versions either - I just checked a disassembly of version 0.21.93.19a (i.e. the very first public release) and it had the same problem, so this has never worked correctly.

Furthermore, even if this particular bug gets fixed, only nobles will get thoughts from tomb quality, since it skips giving out thoughts if the dwarf's "desired tomb quality" is zero.
(0023605)
Quietust (reporter)
2012-09-24 11:10

There's actually another bug hidden beneath this one - if a dwarf gets the "worried greatly about not having a tomb after gaining another year" thought, the happiness penalty will be based on the dwarf's desired office quality rather than the desired tomb quality.
(0038454)
Shonai_Dweller (reporter)
2018-06-09 22:26

Someone's just remarked on receiving this message with a screenshot on Reddit. It's a 44.10 screenshot (includes memories), so presumably the reshuffle of numbers for the stress release finally got this working.
(0038456)
hittemvvvhard (reporter)
2018-06-10 12:58

reddit post: https://www.reddit.com/r/dwarffortress/comments/8pvpqj/today_was_my_birthday_i_really_should_have_got_a/?st=ji976edq&sh=288896d4 [^]
(0038459)
Loci (manager)
2018-06-11 15:37

Thanks for the update.

I'm not sure if tomb-quality thoughts are intended to apply to non-noble dwarves, but that would seem to be less of a bug and more of a suggestion.

The calculation error using desired office quality instead of desired tomb quality, however, is a bug, if that is still the case in the current version. The effect is minor since almost all nobles have equivalent office and tomb quality demands. Presumably this bug can be tested by modding nobles with lowered tomb demands and checking if they are satisfied with those low quality tombs or demand office-quality tombs instead (or just checking the code again).

- Issue History
Date Modified Username Field Change
2012-04-26 10:55 Quietust New Issue
2012-04-26 12:56 kwieland Note Added: 0022381
2012-08-17 08:18 Quietust Note Added: 0023469
2012-09-24 11:10 Quietust Note Added: 0023605
2018-06-09 22:26 Shonai_Dweller Note Added: 0038454
2018-06-10 12:58 hittemvvvhard Note Added: 0038456
2018-06-11 15:37 Loci Note Added: 0038459
2018-06-11 15:37 Loci Assigned To => Loci
2018-06-11 15:37 Loci Status new => needs feedback


Copyright © 2000 - 2010 MantisBT Group
Powered by Mantis Bugtracker