Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0005854Dwarf FortressDwarf Mode -- Diplomacypublic2012-04-30 19:132015-12-02 13:42
Assigned ToToady One 
PrioritynormalSeverityminorReproducibilityhave not tried
PlatformOSOS Version
Product Version0.34.07 
Target VersionFixed in Version0.40.05 
Summary0005854: Diplomats don't bring bodyguards
DescriptionBack in the old 2D versions of Dwarf Fortress, Human diplomats were escorted by a pair of swordsmen, and this behavior was linked to their [PLAINS_SETTLEMENTS] raw token. In version, this behavior was split off to the [DIPLOMAT_BODYGUARDS] token, but at least since it hasn't actually done anything - Human diplomats always arrived alone and unprotected.

In an effort to track down this problem, I located the code for diplomat arrival in 0.34.07 and the check against [DIPLOMAT_BODYGUARDS], and I've determined why it's not working: the game builds a list of valid military professions and then checks whether or not that list is empty before proceeding to create the bodyguards, but the condition is backwards, so it only proceeds if the list is empty (rather than non-empty).

The following binary patch fixes this bug in Win32 v0.34.07 SDL:
00476328 : 85 -> 84
Tagsbinary patch
Attached Files

- Relationships
related to 0005098resolvedToady One "Friendly" migrants with Trader profession act like on-the-job merchants 

-  Notes
Quietust (reporter)
2012-04-30 20:49
edited on: 2012-06-12 13:34

Interestingly, when the diplomat bodyguards do arrive, they show up as "Merchant" in the Units screen if a caravan is present and "Friendly" if no caravan is present, exactly the same as with caravan guards.

Quietust (reporter)
2012-06-07 06:15

Updated patch for Win32 v0.34.11 SDL:
0493E28 : 85 -> 84

- Issue History
Date Modified Username Field Change
2012-04-30 19:13 Quietust New Issue
2012-04-30 19:13 Quietust Tag Attached: binary patch
2012-04-30 20:49 Quietust Note Added: 0022408
2012-05-01 09:06 daenyth Issue Monitored: daenyth
2012-05-22 12:47 eatatree Issue Monitored: eatatree
2012-05-22 15:03 Footkerchief Relationship added related to 0005098
2012-05-22 21:14 Quietust Note Edited: 0022408 View Revisions
2012-06-07 06:15 Quietust Note Added: 0022890
2012-06-12 13:34 Quietust Note Edited: 0022408 View Revisions
2014-01-15 14:41 Kirig Stonebeard II Issue Monitored: Kirig Stonebeard II
2014-01-17 10:09 Kirig Stonebeard Issue Monitored: Kirig Stonebeard
2014-03-25 13:13 Dwarfu Assigned To => Dwarfu
2014-03-25 13:13 Dwarfu Status new => acknowledged
2014-07-23 10:21 Toady One Status acknowledged => resolved
2014-07-23 10:21 Toady One Fixed in Version => Next Version
2014-07-23 10:21 Toady One Resolution open => fixed
2014-07-23 10:21 Toady One Assigned To Dwarfu => Toady One
2015-12-02 13:42 eatatree Issue End Monitor: eatatree

Copyright © 2000 - 2010 MantisBT Group
Powered by Mantis Bugtracker