Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0009762Dwarf FortressMiscellaneous Crashespublic2016-05-17 02:462017-11-11 16:54
Reporteralexchandel 
Assigned Tolethosor 
PrioritynormalSeveritycrashReproducibilityalways
StatusconfirmedResolutionopen 
PlatformOSOS XOS Version10.11.4
Product Version0.43.02 
Target VersionFixed in Version 
Summary0009762: Dwarf Fortress immediately crashes when using system full screen toggle (green button) on OS X 10.10+
DescriptionDwarf Fortress immediately crashes whenever the window is maximized by clicking the standard green button in the corner of the window. Normally, the window would simply be resized to fullscreen. cropping or blacking what it needed to. But dwarf fortress immediately crashes. There is no opportunity to save the game state. No other OS X application does this. This crash is replicable and occurs 100% of the time.
Steps To Reproduce1. Run dwarf fortress on OS X.
2. Click the green "Full Screen" icon in the corner of the window.
3. Dwarf fortress crashes immediately.
Additional InformationThis happened to me the very first time I played DF, after spending hours in the game. All progress was lost. I've never seen a game with such a blatant, user-accessible crash.
TagsSDL
Attached Files

- Relationships
has duplicate 0009912resolvedlethosor game crash going full screen 
related to 0009962confirmedlethosor Window disappears when clicking on upper edge of title bar (32-bit DF only) 

-  Notes
(0035208)
lethosor (manager)
2016-05-17 16:51

Does the fix in 0005260 work?
Sorry about this :/. Toady uses an older version of OS X than what you're using, so if that is the issue, he wouldn't be experiencing this.
(0035225)
alexchandel (reporter)
2016-05-18 05:28

... Sort of. It still crashes sometimes, for example 100% of the time during the opening movie, but not 100% of the time for the game.

However, it's not ideal. It produces a buggy fullscreen, with the window chrome still drawn around the window. It appears that dwarffortress realizes that it's in fullscreen, and redraws itself in a new window inside the fullscreen space. This means that repeatedly clicking the green button in the window chrome will repeatedly produce other (non-functional, blank, completely white) fullscreen window that can never be removed. Moreover, because dwarffortress is still drawing itself in this small subwindow, it can now never be taken out of fullscreen mode.

All of this might be fixed by building against the correct version of SDL. Could this happen sooner? I install via Homebrew, the OS X package manager, and unless a maintainer here submits a PR updating the package formula, it'll probably take an additional few weeks for even that to get updated :\
(0035226)
alexchandel (reporter)
2016-05-18 05:33

Actually, it turns out that even trying to bring it back to normal, after having maximized it, by clicking the green button sometimes crashes it during normal gameplay. Man, I feel like I'm walking on broken glass with this window chrome.
(0035227)
Dame de la Licorne (reporter)
2016-05-18 06:39
edited on: 2016-05-18 06:40

I just tested this (simply to confirm that it does the same thing on my OSX machine). I don't normally use the green button to full-screen my game, but if you start with the window at a small size, then double-click on the DF title bar (the one that contains the three buttons), it will become "full-screen" (it's not really, but it adjusts to the computer screen size) without crashing.

Note: I have my init file set to allow in-game window resizing.

Does that work for you?

(0035287)
alexchandel (reporter)
2016-05-24 14:33

It does, but that's the same as just resizing the window as large as possible. The window chrome is still visible however, as is the menu bar. And other programs below it are free to open popups/panels, which are displayed on top of dwarf fortress.

OSX's fullscreen mode is special, and should be supported. It essentially gives a separate desktop to the program, with no window chrome, menu bar, or other programs' windows. Distraction-free dwarf fortress is the goal, anyways.

Dame, were you able to confirm the fullscreen crash, and the crash & glitches with the swapped-in-place SDL framework?
(0035288)
Dame de la Licorne (reporter)
2016-05-24 15:52

I did confirm the fullscreen crash, but haven't attempted to reproduce the SDL-related stuff.
(0035338)
lethosor (manager)
2016-05-30 17:14
edited on: 2016-05-30 17:16

It sounds like this is an SDL issue, and we really can't fix SDL. I'm surprised that SDL 1.2.15 is still crashing, as most people have reported that it works just fine. If it really is, there's not much we can do here, unless Toady decides to update to SDL 2, which would be a lot of work.

(0035698)
lethosor (manager)
2016-07-23 19:26

Has this changed in 0.43.05?
(0035862)
lethosor (manager)
2016-09-09 10:57

Confirmed in 0.43.05 with PRINT_MODE:STANDARD.
(0036000)
alexchandel (reporter)
2016-10-26 12:52

Confirmed in 0.43.05 with PRINT_MODE:STANDARD on macOS 10.12.0.

Note that PRINT_MODE:STANDARD is still necessary on macOS 10.12 because PRINT_MODE:2D uses 57% CPU, which is unacceptable.

You should really consider updating to SDL 2, it has perfect support for OSX's fullscreen. Is there are crash log somewhere I can upload for you to fix this?
(0036004)
alexchandel (reporter)
2016-10-26 13:40

Crash confirmed as well with PRINT_MODE:VBO, PRINT_MODE:SHADER, PRINT_MODE:PARTIAL:0, PRINT_MODE:PARTIAL:1, PRINT_MODE:PARTIAL:2, and PRINT_MODE:FRAME_BUFFER.

In short, every mode but 2D. And PRINT_MODE:2D is basically unusable due to its massive CPU usage WHEN PAUSED.
(0036478)
lethosor (manager)
2017-04-29 11:56

Just a note: holding down "alt" when pressing the green button makes the window as large as possible without entering full-screen mode (similar to double-clicking the title bar).
(0036488)
lethosor (manager)
2017-05-01 18:20

Mifki has put together an SDL build that seems to fix this, at least for him and me: https://www.dropbox.com/s/vobjcytkiguxky9/SDL.framework.zip?dl=0 [^]

(Replace libs/SDL.framework with this one)
(0036525)
alexchandel (reporter)
2017-05-12 09:55

Mifki's SDL build fixes this issue. I notice it opts out of the "resize to fullscreen" animation, so I wonder if that animation influenced the crash.
(0036534)
lethosor (manager)
2017-05-17 14:05

It doesn't have anything to do with the animation - on my end, the window animates (somewhat) but the contents don't until it reaches its final size, which is also the case when maximizing the window with "alt" (with and without mifki's SDL build).
(0036862)
alexchandel (reporter)
2017-11-11 16:54

Any chance of Mifki's SDL build making it into the upcoming version of DF?

- Issue History
Date Modified Username Field Change
2016-05-17 02:46 alexchandel New Issue
2016-05-17 16:51 lethosor Note Added: 0035208
2016-05-17 16:51 lethosor Assigned To => lethosor
2016-05-17 16:51 lethosor Status new => needs feedback
2016-05-18 05:28 alexchandel Note Added: 0035225
2016-05-18 05:28 alexchandel Status needs feedback => assigned
2016-05-18 05:33 alexchandel Note Added: 0035226
2016-05-18 06:39 Dame de la Licorne Note Added: 0035227
2016-05-18 06:40 Dame de la Licorne Note Edited: 0035227 View Revisions
2016-05-24 14:33 alexchandel Note Added: 0035287
2016-05-24 15:52 Dame de la Licorne Note Added: 0035288
2016-05-30 17:14 lethosor Note Added: 0035338
2016-05-30 17:16 lethosor Note Edited: 0035338 View Revisions
2016-07-23 19:26 lethosor Note Added: 0035698
2016-07-23 19:26 lethosor Status assigned => needs feedback
2016-08-09 11:45 lethosor Relationship added related to 0009962
2016-09-09 10:57 lethosor Note Added: 0035862
2016-09-09 10:57 lethosor Status needs feedback => confirmed
2016-09-09 10:58 lethosor Relationship added has duplicate 0009912
2016-09-11 11:58 lethosor Summary Dwarf Fortress immediately crashes when maximizing window on OS X => Dwarf Fortress immediately crashes when using system full screen toggle (green button) on OS X 10.10+
2016-10-26 12:52 alexchandel Note Added: 0036000
2016-10-26 13:40 alexchandel Note Added: 0036004
2017-04-29 11:56 lethosor Note Added: 0036478
2017-05-01 18:20 lethosor Note Added: 0036488
2017-05-12 09:55 alexchandel Note Added: 0036525
2017-05-12 09:55 alexchandel Tag Attached: SDL
2017-05-17 14:05 lethosor Note Added: 0036534
2017-11-11 16:54 alexchandel Note Added: 0036862


Copyright © 2000 - 2010 MantisBT Group
Powered by Mantis Bugtracker