Dwarf Fortress Bug Tracker - Dwarf Fortress
View Issue Details
0010710Dwarf FortressMiscellaneous Crashespublic2018-04-16 14:092018-05-06 10:17
windowswindowswin7 64b
0010710: Crash upon caravan arrival / returning raid

in my current game, I got a 100% crash upon the arrival of the caravan.

Here is a link to the bugged save:
http://dffd.bay12games.com/file.php?id=13683 [^]

Load saved game and wait for the caravan to arrive. Game will crash just after.
No tags attached.
duplicate of 0010369confirmed Dwarfu Game crash (likely) when Dwarves return from mission 
Issue History
2018-04-16 14:09behbehrNew Issue
2018-04-16 18:21LociNote Added: 0038174
2018-04-16 18:21LociAssigned To => Loci
2018-04-16 18:21LociStatusnew => needs feedback
2018-04-17 02:08PatrikLundellNote Added: 0038175
2018-04-17 02:43PatrikLundellNote Edited: 0038175bug_revision_view_page.php?bugnote_id=0038175#r15522
2018-04-17 10:08behbehrNote Added: 0038176
2018-04-17 10:08behbehrStatusneeds feedback => assigned
2018-04-17 11:15PatrikLundellNote Added: 0038178
2018-04-17 15:01behbehrNote Added: 0038180
2018-04-17 15:56LociStatusassigned => confirmed
2018-04-17 15:59LociRelationship addedrelated to 0010369
2018-04-17 16:00LociSummaryCrash upon caravan arrival => Crash upon caravan arrival / returning raid
2018-04-17 16:18PatrikLundellNote Added: 0038182
2018-04-18 10:56HuntthetrollIssue Monitored: Huntthetroll
2018-04-23 12:07behbehrNote Added: 0038195
2018-05-06 10:17LociNote Added: 0038259
2018-05-06 10:17LociRelationship replacedduplicate of 0010369
2018-05-06 10:17LociStatusconfirmed => resolved
2018-05-06 10:17LociResolutionopen => duplicate
2018-05-07 07:07HuntthetrollIssue End Monitor: Huntthetroll

2018-04-16 18:21   
The save crashed reliably for me too.

Your raw folder claims "baselines/df_44_05" and "graphics/Phoebus" were installed. Was this save originally created in v0.44.05 (with those mods) and then updated to v0.44.09? Are there any other mods involved?
2018-04-17 02:08   
(edited on: 2018-04-17 02:43)
The Sparrow Man invaders are fishy, indicating mods. However, I suspect the crashing is unrelated to either those or the caravan, but rather is connected to the squads returning from a raid. The citizen count is stepping upwards as the crash approaches, indicating units are entering the map when returning. My guess is that it's something related to one of those returning militia members.

Edit: The save was created with 0.44.02 according to the worldgen data.

Hm, after having it crash a number of times at what seemed to be the same place I tried to see who the last returning squad member before it crashing was. However, on that run they all returned, so it seems there's a random factor involved in it crashing most of the time (uninitialized memory? out of bounds memory access?).

Anyway, I decided to save and upload the progressed save at this point (presumably past the crash point) to allow the OP to continue playing. Note that DF crashed on saving, but I was able to load the save and it contains the returned squads. The progressed save is here: http://dffd.bay12games.com/file.php?id=13686 [^]
Note that there is no guarantee the save isn't corrupt in some way.

2018-04-17 10:08   

yes sorry for the lack of info.

The save was originaly from 0.44.2, imported in 0.44.5 then in 0.44.9
I am using PerridexisErrant, using dfHack and phoebus graphic sets.
dfHack is mainly used for Quicksave and autodump, it may have corrupted the savegame.

There is indeed 2 or 3 squads returning from a raid at that time.

Thank you for the updated save, I will have a look at it.

As the original game is still crashing on my side, if any more info is needed about the returning dwarves, I will be happy to provide it.
2018-04-17 11:15   
There are 3 returning squads, and it seemed it crashed at about a civ member count of 140 or 141 (as per the Units screen) as it ticks up for each returning member.
The save crashed for me 3 or 4 times using a mixture of vanilla and DFHack (disappearing with DFHack, tossing up a Windows error prompt with vanilla). Only after that did things go through without crashing, so I may have been lucky and decided to catch it in a jar when I got the chance. I didn't do anything in the save apart from observing things, so some "haul junk to the trade depot" time is lost, and there were a number of reports of cancelled jobs.

What about the Sparrow Man invaders? There are 6 or so of them. Where do they come from? A vanilla civ or a modded one?
2018-04-17 15:01   
that is strange, I did not notice the invaders before. I am not using any moded civ, but I got ambushed by elves recently, maybe they came along and got stuck in the trees ...
2018-04-17 16:18   
The invaders are there in the original save, and I think somebody got scared of them in one run. Animal people with elves makes some sense, though.
2018-04-23 12:07   
I managed to play a bit after having avoided the crash.
No problem during some time, so I decided to send the 3 squads on raid again, same target.
A bit later, game crashed again. I relaunched the game 4 or 5 times until I managed to bypass the crashing point... to discover that raiders where just coming back.

So I suspect this is linked to something the raiders are bringing along.
Would the raid result be generated when they enter the map ?
This would explain that as long as something is present in their loot, it crashes ?
2018-05-06 10:17   
v0.44.10: Looks like this was a raid duplicate equipment crash (0010369). From errorlog.txt:

Duplicate inventory removed: (bronze shield) from Kogsak Togalatir, Macedwarf
Duplicate inventory removed: (bronze shield) from Mosus Oddomaral, champion