(0040697)
|
Quietust
|
2020-08-21 10:41
(edited on: 2020-08-21 11:30) |
|
A recent DFHack bug report (https://github.com/DFHack/dfhack/issues/1629 [^]) revealed that "masterpiece lost" events all had nonsense values for the "histfig" field, so I did a bit of disassembly diving and determined that this field is not being initialized to -1 as it's supposed to; instead, it typically ends up with a value of zero (which causes the event to be attributed to the first histfig in the world) or a totally random value, presumably depending on how long the game's been running.
I've confirmed that this problem dates back to at least version 0.28.181.40d, and likely all the way back to version 0.27.176.38a when this history event was first introduced.
For what it's worth, the "site" field isn't being initialized either, which could result in garbage being reported for masterworks destroyed out in the wilderness; similarly, the "destruction type" field is also uninitialized in most scenarios, which might explain the above-mentioned incidents of items being erroneously reported as having "melted".
|
|