0006026: Melting coins creates too much metal

(0023015)
Quietust (reporter)
2012-06-15 08:53

The simplest solution to this problem would be to subtract 1 from the stack size before performing the division - since an item can never have a stack size of zero, this should work as intended.

This problem technically also exists with ammo (99 bolts would give 1 bar, 100 bolts would give 1.1 bars), but it's not an issue since forging metal bolts only gives you a stack of 25.

(0023021)
Quietust (reporter)
2012-06-15 13:51
edited on: 2012-06-22 17:14

There are several other item types which melt down to yield exactly the same amount of metal that was needed to make them: chains, instruments, animal traps, and buckets. Interestingly, buckets have had a 1 bar melt yield ever since 0.23.130.23a (and possibly earlier), while the others only yielded 0.5 bars prior to 0.34.06.

(0030206)
Quietust (reporter)
2014-09-15 17:33

Confirmed still present in 0.40.12

(0032316)
jwoodward48df (reporter)
2015-03-03 07:35

This problem does exist with bolts.

(0032320)
Quietust (reporter)
2015-03-03 17:32

jwoodward48df: just like I said in my original comment above...

Issue History
Date Modified	Username	Field	Change
2012-06-15 08:51	Quietust	New Issue
2012-06-15 08:53	Quietust	Note Added: 0023015
2012-06-15 13:51	Quietust	Note Added: 0023021
2012-06-15 13:52	Footkerchief	Relationship added	related to 0006027
2012-06-16 08:01	Quietust	Note Edited: 0023021	View Revisions
2012-06-22 17:14	Quietust	Note Edited: 0023021	View Revisions
2014-09-15 17:33	Quietust	Note Added: 0030206
2014-09-15 17:50	Footkerchief	Assigned To	=> Footkerchief
2014-09-15 17:50	Footkerchief	Status	new => confirmed
2014-09-23 19:16	Footkerchief	Relationship added	related to 0008339
2015-03-03 07:35	jwoodward48df	Note Added: 0032316
2015-03-03 17:32	Quietust	Note Added: 0032320

Notes
(0023015) Quietust (reporter) 2012-06-15 08:53	The simplest solution to this problem would be to subtract 1 from the stack size before performing the division - since an item can never have a stack size of zero, this should work as intended. This problem technically also exists with ammo (99 bolts would give 1 bar, 100 bolts would give 1.1 bars), but it's not an issue since forging metal bolts only gives you a stack of 25.

(0023021) Quietust (reporter) 2012-06-15 13:51 edited on: 2012-06-22 17:14	There are several other item types which melt down to yield exactly the same amount of metal that was needed to make them: chains, instruments, animal traps, and buckets. Interestingly, buckets have had a 1 bar melt yield ever since 0.23.130.23a (and possibly earlier), while the others only yielded 0.5 bars prior to 0.34.06.

(0030206) Quietust (reporter) 2014-09-15 17:33	Confirmed still present in 0.40.12

(0032316) jwoodward48df (reporter) 2015-03-03 07:35	This problem does exist with bolts.

(0032320) Quietust (reporter) 2015-03-03 17:32	jwoodward48df: just like I said in my original comment above...